-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource: add tidb-pdf-generation-tutorial.md #16134
resource: add tidb-pdf-generation-tutorial.md #16134
Conversation
/translation from-docs-cn |
4. Generate document PDF: | ||
|
||
```bash | ||
bash scripts/generate_pdf.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be nice to have a Makefile
to do the generation of doc.md
and PDF.
default: output.pdf
doc.md:
./scripts/merge_by_toc.py
output.pdf: doc.md
./scripts/generate_pdf.sh
Then make output.pdf
would run merge_by_toc.py
if there is no doc.md
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it can save one step 👍
Maybe we should also mention |
4. Generate document PDF: | ||
|
||
```bash | ||
bash scripts/generate_pdf.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it can save one step 👍
Co-authored-by: Grace Cai <[email protected]>
Co-authored-by: Grace Cai <[email protected]>
Co-authored-by: Grace Cai <[email protected]>
@dveeden: Your lgtm message is repeated, so it is ignored. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
fix this: ``` [2024-01-23T09:09:05.602Z] resources/tidb-pdf-generation-tutorial.md: 85: MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2] [2024-01-23T09:09:05.602Z] resources/tidb-pdf-generation-tutorial.md: 92: MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2] ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
fix this error. ``` [2024-01-25T10:17:03.126Z] resources/tidb-pdf-generation-tutorial.md: 10: MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2] [2024-01-25T10:17:03.126Z] resources/tidb-pdf-generation-tutorial.md: 15: MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2] ```
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
First-time contributors' checklist
What is changed, added or deleted? (Required)
translation
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?